TPC attach 2 framework #1296
Merged
TPC attach 2 framework #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'attach' method that returns a TPC
ofirgo
commented
Dec 18, 2024
model_compression_toolkit/target_platform_capabilities/schema/v1.py
Outdated
Show resolved
Hide resolved
ofirgo
commented
Dec 18, 2024
...oolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2keras.py
Show resolved
Hide resolved
haihabi
reviewed
Dec 18, 2024
...oolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2keras.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/target_platform_capabilities/schema/mct_current_schema.py
Outdated
Show resolved
Hide resolved
...n_toolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2fw.py
Outdated
Show resolved
Hide resolved
...n_toolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2fw.py
Show resolved
Hide resolved
...n_toolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2fw.py
Show resolved
Hide resolved
...n_toolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2fw.py
Outdated
Show resolved
Hide resolved
...n_toolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2fw.py
Outdated
Show resolved
Hide resolved
...n_toolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2fw.py
Show resolved
Hide resolved
...n_toolkit/target_platform_capabilities/target_platform/targetplatform2framework/attach2fw.py
Show resolved
Hide resolved
lior-dikstein
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Implementing TPC Attach2Fw module to attach a given TPC model to the framework-specific operators.
The attachments is based on a hardcoded mapping between the TPC schema's OperatorSetNames enum to each framework layers and ops (keras/pytorch).
Note that current TPCs do not use this module, since they will be removed and replaced with a simpler initialization framework in the future. So currently, this module is not used in MCT but it is just a preparation for future modifications.
Checklist before requesting a review: